Re: [PATCH v2] selftests/intel_pstate: fix operand expected

[Shuah Khan]

On 10/14/24 11:21, Alessandro Zanni wrote:
> This fix solves theses errors, when calling kselftest with
> targets "intel_pstate":
>
> ./run.sh: line 90: / 1000: syntax error: operand expected (error token is "/ 1000")
>
> ./run.sh: line 92: / 1000: syntax error: operand expected (error token is "/ 1000")
>
> To error was found by running tests manually with the command:
> make kselftest TARGETS=intel_pstate
>
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@xxxxxxxxx>
> ---
>
> Notes:
>      v2: removed debug echos

See my comments on your v1. It would help to wait a bit
to send v2.

I can't reproduce this problem on Linux 6.12-rc3.
What's you environment like?

>   tools/testing/selftests/intel_pstate/run.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> index e7008f614ad7..0c1b6c1308a4 100755
> --- a/tools/testing/selftests/intel_pstate/run.sh
> +++ b/tools/testing/selftests/intel_pstate/run.sh
> @@ -87,9 +87,9 @@ mkt_freq=${_mkt_freq}0
>   
>   # Get the ranges from cpupower
>   _min_freq=$(cpupower frequency-info -l | tail -1 | awk ' { print $1 } ')
> -min_freq=$(($_min_freq / 1000))
> +min_freq=$((_min_freq / 1000))
>   _max_freq=$(cpupower frequency-info -l | tail -1 | awk ' { print $2 } ')
> -max_freq=$(($_max_freq / 1000))
> +max_freq=$((_max_freq / 1000))
>   
>   
>   [ $EVALUATE_ONLY -eq 0 ] && for freq in `seq $max_freq -100 $min_freq`

thanks,
-- Shuah