Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add IBM SBP1 board

[Andrew Jeffery]

Hi Naresh,

On Fri, 2024-10-11 at 13:38 +0530, Naresh Solanki wrote:
> Hi Andrew,
> 
> 
> On Fri, 11 Oct 2024 at 05:15, Andrew Jeffery
> <andrew@xxxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > Hi Naresh,
> > 
> > On Thu, 2024-10-10 at 09:30 -0500, Rob Herring (Arm) wrote:
> > > On Thu, 10 Oct 2024 16:53:31 +0530, Naresh Solanki wrote:
> > > > Document the new compatibles used on IBM SBP1.
> > > > 
> > > > Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>
> > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > > > ---
> > > > Changes in V4:
> > > > - Retain Acked-by from v2.
> > > > - Fix alphabetic order
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > 
> > > 
> > > My bot found new DTB warnings on the .dts files added or changed in this
> > > series.
> > > 
> > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > > are fixed by another series. Ultimately, it is up to the platform
> > > maintainer whether these warnings are acceptable or not. No need to reply
> > > unless the platform maintainer has comments.
> > > 
> > > If you already ran DT checks and didn't see these error(s), then
> > > make sure dt-schema is up to date:
> > > 
> > >  pip3 install dtschema --upgrade
> > > 
> > > 
> > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-sbp1.dtb' for 20241010112337.3840703-1-naresh.solanki@xxxxxxxxxxxxx:
> > > 
> > 
> > ...
> > 
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mux@77: interrupts: False schema does not allow [[44, 4]]
> > >  from schema $id: http://devicetree.org/schemas/i2c/i2c-mux-pca954x.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >  from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
> > 
> > These still must be addressed as mentioned on v3 (with more specific
> > comments regarding the infineon,ir38263 on v4). Please look through the
> > binding documents for the affected nodes and make sure the nodes in
> > your DTS conform to their definitions. You can check your work with
> > `make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-sbp1.dtb` prior to sending.
> 
> These are the warnings coming for trivial devices. Even for regulator@5f
> 
> grep -rsn mp2973 Documentation/
> Documentation/devicetree/bindings/trivial-devices.yaml:286:
> # Monolithic Power Systems Inc. multi-phase controller mp2973
> Documentation/devicetree/bindings/trivial-devices.yaml:287: -
> mps,mp2973
> 

Right, but if they're generating warnings, then you haven't specified
the nodes in accordance with the bindings. From here one of two things
is the case:

   1. The bindings' specifications are incomplete, and you need to
      introduce patches updating them to match how you need to use the
      hardware
   2. Your devicetree is incorrect, and the unexpected properties need
      to be removed from the listed nodes.

The only third option is "don't use the hardware how you need to" (i.e.
remove the unexpected properties despite needing them, because you
don't want to update the bindings).

Ultimately the tools are telling you something is wrong, and I need the
warnings I've identified addressed before I can apply your patch,
otherwise the hardware is not going to do what you might expect.
> I've rebased it on top of for-next branch in [2]
> 
> I rebased on top of [1] & the volume of output did reduce for CHECK_DTBS.

Great :)

Andrew