Re: [PATCH -next] selftests/cgroup: Fix compile error in test_cpu.c

From: Tejun Heo
Date: Mon Oct 14 2024 - 21:06:36 EST


On Fri, Oct 11, 2024 at 06:11:53AM +0000, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>
>
> When compiling the cgroup selftests with the following command:
>
> make -C tools/testing/selftests/cgroup/
>
> the compiler complains as below:
>
> test_cpu.c: In function ‘test_cpucg_nice’:
> test_cpu.c:284:39: error: incompatible type for argument 2 of ‘hog_cpus_timed’
> 284 | hog_cpus_timed(cpucg, param);
> | ^~~~~
> | |
> | struct cpu_hog_func_param
> test_cpu.c:132:53: note: expected ‘void *’ but argument is of type ‘struct cpu_hog_func_param’
> 132 | static int hog_cpus_timed(const char *cgroup, void *arg)
> | ~~~~~~^~~
>
> Fix it by passing the address of param to hog_cpus_timed().
>
> Fixes: 2e82c0d4562a ("cgroup/rstat: Selftests for niced CPU statistics")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>

Applied to cgroup/for-6.13.

Thanks.

--
tejun