Re: [PATCH] Revert "blk-throttle: Fix IO hang for a corner case"

From: Xiuhong Wang
Date: Mon Oct 14 2024 - 21:46:41 EST


Hi Michal,

Remove this patch to make the code clearer and easier to understand.

Michal Koutný <mkoutny@xxxxxxxx> 于2024年10月15日周二 00:45写道:
>
> Hello.
>
> On Fri, Oct 11, 2024 at 09:47:24AM GMT, Xiuhong Wang <xiuhong.wang@xxxxxxxxxx> wrote:
> > This reverts commit 5b7048b89745c3c5fb4b3080fb7bced61dba2a2b.
> >
> > The throtl_adjusted_limit function was removed after
> > commit bf20ab538c81 ("blk-throttle: remove
> > CONFIG_BLK_DEV_THROTTLING_LOW"), so the problem of not being
> > able to scale after setting bps or iops to 1 will not occur.
> > So revert this commit that bps/iops can be set to 1.
>
> What is the use case where the difference between 1 or 2 matters?
> (Unless this is meant as a cleanup, then it makes sense to me.)
>
> Thanks
> Michal