Re: [PATCH net-next v2 0/6] rust: Add IO polling

From: FUJITA Tomonori
Date: Mon Oct 14 2024 - 23:17:10 EST


On Mon, 14 Oct 2024 14:18:57 -0700
Boqun Feng <boqun.feng@xxxxxxxxx> wrote:

>> This patchset adds Delta (also belongs to time, I guess) and fsleep to
>> rust/kernel/time.rs. I think that fsleep belongs to timer (because
>> sleep functions in kernel/time/timer.c). It's better to add
>> rust/kerne/time/timer.rs for fsleep() rather than putting both time
>> and timer stuff to rust/kernel/time.rs?
>>
>
> Good point. So how about putting fsleep() into rusk/kernel/time/delay.rs
> and add that into the "F:" entry of TIMER subsystem? Since "sleep"s are
> a set of particular usage of timers which don't directly interact with a
> timer or hrtimer struct, so I feel it's better to have their own
> file/mod rather than sharing it with timers. Plus this results in less
> potential conflicts with Andreas' hrtimer series.

Sure. I'll go with rust/kernel/time/delay.rs.