Re: [PATCH ipsec v3] xfrm: fix one more kernel-infoleak in algo dumping

[Steffen Klassert]

On Tue, Oct 08, 2024 at 02:02:58PM +0500, Petr Vaganov wrote:
> During fuzz testing, the following issue was discovered:
> 
> BUG: KMSAN: kernel-infoleak in _copy_to_iter+0x598/0x2a30

...

> 
> Bytes 328-379 of 732 are uninitialized
> Memory access of size 732 starts at ffff88800e18e000
> Data copied to user address 00007ff30f48aff0
> 
> CPU: 2 PID: 18167 Comm: syz-executor.0 Not tainted 6.8.11 #1
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
> 
> Fixes copying of xfrm algorithms where some random
> data of the structure fields can end up in userspace.
> Padding in structures may be filled with random (possibly sensitve)
> data and should never be given directly to user-space.
> 
> A similar issue was resolved in the commit
> 8222d5910dae ("xfrm: Zero padding when dumping algos and encap")
> 
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
> 
> Fixes: c7a5899eb26e ("xfrm: redact SA secret with lockdown confidentiality")
> Cc: stable@xxxxxxxxxxxxxxx
> Co-developed-by: Boris Tonofa <b.tonofa@xxxxxxxx>
> Signed-off-by: Boris Tonofa <b.tonofa@xxxxxxxx>
> Signed-off-by: Petr Vaganov <p.vaganov@xxxxxxxx>

Applied, thanks a lot!