Re: [PATCH v4 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

[Soutrik Mukhopadhyay]

On 10/7/2024 1:21 AM, Dmitry Baryshkov wrote:
> On Fri, Oct 04, 2024 at 04:00:46PM GMT, Soutrik Mukhopadhyay wrote:
> > The Qualcomm SA8775P platform comes with 2 DisplayPort controllers
> > for each mdss, having different base offsets than the previous
> > SoCs. The support for all 4 DPTX have been added here, and
> > validation of only MDSS0 DPTX0 and DPTX1 have been conducted.
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@xxxxxxxxxxx>
> > ---
> > v2: No change
> >
> > v3: Fixed review comments from Konrad and Bjorn
> > 	-Added all the necessary DPTX controllers for this platform.
> >
> > v4: Updated commit message
> >
> > ---
> >   drivers/gpu/drm/msm/dp/dp_display.c | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > index e1228fb093ee..2195779584dc 100644
> > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > @@ -118,6 +118,14 @@ struct msm_dp_desc {
> >   	bool wide_bus_supported;
> >   };
> >   
> > +static const struct msm_dp_desc sa8775p_dp_descs[] = {
> > +	{ .io_start = 0xaf54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true },
> > +	{ .io_start = 0xaf5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true },
> > +	{ .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_2, .wide_bus_supported = true },
> > +	{ .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_3, .wide_bus_supported = true },
> Please take a look at other device descriptions in the file, note the
> difference and fix your DP description accordingly.


Sure, we will update the device descriptions, specifically the address 
under io_start, for DP_CONTROLLER_0 and DP_CONTROLLER_1

in the next version.


> > +	{}
> > +};
> > +
> >   static const struct msm_dp_desc sc7180_dp_descs[] = {
> >   	{ .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true },
> >   	{}
> > @@ -162,6 +170,7 @@ static const struct msm_dp_desc x1e80100_dp_descs[] = {
> >   };
> >   
> >   static const struct of_device_id dp_dt_match[] = {
> > +	{ .compatible = "qcom,sa8775p-dp", .data = &sa8775p_dp_descs },
> >   	{ .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_descs },
> >   	{ .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_descs },
> >   	{ .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_descs },
> > --
> > 2.17.1