Re: [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper

From: Johannes Berg
Date: Tue Oct 15 2024 - 03:46:40 EST


On Tue, 2024-10-15 at 07:32 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The lib80211 code uses arc4 crypto helpers that can be
> disabled:
>
> ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
> ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
>
> Select the library from Kconfig to ensure this can be called.
>
> Fixes: 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")

Right, sorry. I sent a similar one before:

https://lore.kernel.org/linux-wireless/20241011115820.070c468b271d.Iac76e81b5cd9a5b949b8c154381128e8131d581d@changeid/

> +++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
> @@ -6,6 +6,7 @@
> config IPW2100
> tristate "Intel PRO/Wireless 2100 Network Connection"
> depends on PCI && CFG80211
> + select CRYPTO_LIB_ARC4
>
I think this got to the wrong place?

johannes