Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h

[Jiri Slaby]

On 15. 10. 24, 9:50, Christoph Hellwig wrote:
> On Tue, Oct 15, 2024 at 09:47:31AM +0200, Jiri Slaby wrote:
> > > diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> > > index 6797770474a55d..680243751d625f 100644
> > > --- a/drivers/mailbox/omap-mailbox.c
> > > +++ b/drivers/mailbox/omap-mailbox.c
> > > @@ -15,6 +15,7 @@
> > >    #include <linux/slab.h>
> > >    #include <linux/kfifo.h>
> > >    #include <linux/err.h>
> > > +#include <linux/io.h>
> >
> > Oh, I've just noticed this. Why io.h?
>
> Because it would not comple with out it.  To be specific: asm/io.h is
> where __raw_readl and __raw_writel are defined, and we generally prefer
> the Linux over the asm headers.

OK, but how does this relate to "kfifo: don't include dma-mapping.h in 
kfifo.h"?

--
js
suse labs