Re: [PATCH v2 0/4] Add support for APPS SMMU on QCS615

[Krzysztof Kozlowski]

On 15/10/2024 10:15, Qingqing Zhou wrote:
> Enable APPS SMMU function on QCS615 platform. APPS SMMU is required
> for address translation in devices including Ethernet/UFS/USB and
> so on.
> 
> Add the SCM node for SMMU probing normally. SMMU driver probe will
> check qcom_scm ready or not, without SCM node, SMMU driver probe will
> defer.
> The dmesg log without SCM node:
> platform 15000000.iommu: deferred probe pending: arm-smmu: qcom_scm not ready
> 
> With the SCM node, SMMU can probe normally, but SCM driver still fails
> to probe because of one SCM bug:
> qcom_scm firmware:scm: error (____ptrval____): Failed to enable the TrustZone memory allocator
> qcom_scm firmware:scm: probe with driver qcom_scm failed with error 4
> The above SCM bug is fixed by:
> https://lore.kernel.org/all/20241005140150.4109700-2-quic_kuldsing@xxxxxxxxxxx/
> But above patch doesn't impact building of current patch series, this patch
> series can build successfully without above patch.
> 
> Dependency:
> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@xxxxxxxxxxx/
> 
> Changes in v2:
> - Address the comments on bindings from Krzysztof.

Which comments? Be specific what changed.

Best regards,
Krzysztof