arch/riscv/kvm/vcpu_sbi_sta.c:58:20: sparse: sparse: cast to restricted __le32
From: kernel test robot
Date: Tue Oct 15 2024 - 04:52:09 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: eca631b8fe808748d7585059c4307005ca5c5820
commit: e9f12b5fff8ad0eefd0340273767d329ef65fd69 RISC-V: KVM: Implement SBI STA extension
date: 10 months ago
config: riscv-randconfig-r132-20241015 (https://download.01.org/0day-ci/archive/20241015/202410151618.iYFXm2Ip-lkp@xxxxxxxxx/config)
compiler: riscv32-linux-gcc (GCC) 14.1.0
reproduce: (https://download.01.org/0day-ci/archive/20241015/202410151618.iYFXm2Ip-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410151618.iYFXm2Ip-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
arch/riscv/kvm/vcpu_sbi_sta.c:55:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected unsigned int const [noderef] __user *__p @@ got unsigned int [usertype] *[assigned] sequence_ptr @@
arch/riscv/kvm/vcpu_sbi_sta.c:55:13: sparse: expected unsigned int const [noderef] __user *__p
arch/riscv/kvm/vcpu_sbi_sta.c:55:13: sparse: got unsigned int [usertype] *[assigned] sequence_ptr
>> arch/riscv/kvm/vcpu_sbi_sta.c:58:20: sparse: sparse: cast to restricted __le32
arch/riscv/kvm/vcpu_sbi_sta.c:61:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected unsigned int [noderef] __user *__p @@ got unsigned int [usertype] *[assigned] sequence_ptr @@
arch/riscv/kvm/vcpu_sbi_sta.c:61:13: sparse: expected unsigned int [noderef] __user *__p
arch/riscv/kvm/vcpu_sbi_sta.c:61:13: sparse: got unsigned int [usertype] *[assigned] sequence_ptr
arch/riscv/kvm/vcpu_sbi_sta.c:61:13: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int __val @@ got restricted __le32 [usertype] @@
arch/riscv/kvm/vcpu_sbi_sta.c:61:13: sparse: expected unsigned int __val
arch/riscv/kvm/vcpu_sbi_sta.c:61:13: sparse: got restricted __le32 [usertype]
arch/riscv/kvm/vcpu_sbi_sta.c:64:14: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected unsigned long long const [noderef] __user *__p @@ got unsigned long long [usertype] *[assigned] steal_ptr @@
arch/riscv/kvm/vcpu_sbi_sta.c:64:14: sparse: expected unsigned long long const [noderef] __user *__p
arch/riscv/kvm/vcpu_sbi_sta.c:64:14: sparse: got unsigned long long [usertype] *[assigned] steal_ptr
>> arch/riscv/kvm/vcpu_sbi_sta.c:65:25: sparse: sparse: cast to restricted __le64
arch/riscv/kvm/vcpu_sbi_sta.c:68:17: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected unsigned long long [noderef] __user *__p @@ got unsigned long long [usertype] *[assigned] steal_ptr @@
arch/riscv/kvm/vcpu_sbi_sta.c:68:17: sparse: expected unsigned long long [noderef] __user *__p
arch/riscv/kvm/vcpu_sbi_sta.c:68:17: sparse: got unsigned long long [usertype] *[assigned] steal_ptr
arch/riscv/kvm/vcpu_sbi_sta.c:68:17: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned long long __val @@ got restricted __le64 [usertype] @@
arch/riscv/kvm/vcpu_sbi_sta.c:68:17: sparse: expected unsigned long long __val
arch/riscv/kvm/vcpu_sbi_sta.c:68:17: sparse: got restricted __le64 [usertype]
arch/riscv/kvm/vcpu_sbi_sta.c:72:9: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected unsigned int [noderef] __user *__p @@ got unsigned int [usertype] *[assigned] sequence_ptr @@
arch/riscv/kvm/vcpu_sbi_sta.c:72:9: sparse: expected unsigned int [noderef] __user *__p
arch/riscv/kvm/vcpu_sbi_sta.c:72:9: sparse: got unsigned int [usertype] *[assigned] sequence_ptr
arch/riscv/kvm/vcpu_sbi_sta.c:72:9: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int __val @@ got restricted __le32 [usertype] @@
arch/riscv/kvm/vcpu_sbi_sta.c:72:9: sparse: expected unsigned int __val
arch/riscv/kvm/vcpu_sbi_sta.c:72:9: sparse: got restricted __le32 [usertype]
vim +58 arch/riscv/kvm/vcpu_sbi_sta.c
24
25 void kvm_riscv_vcpu_record_steal_time(struct kvm_vcpu *vcpu)
26 {
27 gpa_t shmem = vcpu->arch.sta.shmem;
28 u64 last_steal = vcpu->arch.sta.last_steal;
29 u32 *sequence_ptr, sequence;
30 u64 *steal_ptr, steal;
31 unsigned long hva;
32 gfn_t gfn;
33
34 if (shmem == INVALID_GPA)
35 return;
36
37 /*
38 * shmem is 64-byte aligned (see the enforcement in
39 * kvm_sbi_sta_steal_time_set_shmem()) and the size of sbi_sta_struct
40 * is 64 bytes, so we know all its offsets are in the same page.
41 */
42 gfn = shmem >> PAGE_SHIFT;
43 hva = kvm_vcpu_gfn_to_hva(vcpu, gfn);
44
45 if (WARN_ON(kvm_is_error_hva(hva))) {
46 vcpu->arch.sta.shmem = INVALID_GPA;
47 return;
48 }
49
50 sequence_ptr = (u32 *)(hva + offset_in_page(shmem) +
51 offsetof(struct sbi_sta_struct, sequence));
52 steal_ptr = (u64 *)(hva + offset_in_page(shmem) +
53 offsetof(struct sbi_sta_struct, steal));
54
55 if (WARN_ON(get_user(sequence, sequence_ptr)))
56 return;
57
> 58 sequence = le32_to_cpu(sequence);
59 sequence += 1;
60
61 if (WARN_ON(put_user(cpu_to_le32(sequence), sequence_ptr)))
62 return;
63
64 if (!WARN_ON(get_user(steal, steal_ptr))) {
> 65 steal = le64_to_cpu(steal);
66 vcpu->arch.sta.last_steal = READ_ONCE(current->sched_info.run_delay);
67 steal += vcpu->arch.sta.last_steal - last_steal;
68 WARN_ON(put_user(cpu_to_le64(steal), steal_ptr));
69 }
70
71 sequence += 1;
72 WARN_ON(put_user(cpu_to_le32(sequence), sequence_ptr));
73
74 kvm_vcpu_mark_page_dirty(vcpu, gfn);
75 }
76
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki