Re: [PATCH v4 4/9] misc: amd-sbi: Add support for AMD_SBI IOCTL

[Gupta, Akshay]

On 10/13/2024 8:52 PM, Greg KH wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Thu, Sep 12, 2024 at 07:08:05AM +0000, Akshay Gupta wrote:
> > +     switch (msg.cmd) {
> > +     case 0 ... 0x999:
> > +             /* Mailbox protocol */
> > +             ret = rmi_mailbox_xfer(data, &msg);
> > +             break;
> > +     default:
> > +             pr_err("Command:0x%x not recognized\n", msg.cmd);
> You now just allowed userspace to spam the kernel logs for no good
> reason :(
Thanks, will remove the pr_err to not to spam the logs.
> Also, always use dev_*() calls in a driver, not pr_*() ones, as then you
> will know exactly what driver/device is sending out the message.
Thank you for the input, will do.
> > +             break;
> And you returned the wrong error code if this happens :(
>
> greg k-h
my bad, will take care of this.