Re: [PATCH v4 27/28] media: iris: enable video driver probe of SM8250 SoC

[Dikshita Agarwal]

On 10/14/2024 7:38 PM, Dmitry Baryshkov wrote:
> On Mon, Oct 14, 2024 at 10:00:21PM +0800, Jianhua Lu wrote:
>> On Mon, Oct 14, 2024 at 02:37:48PM +0530, Dikshita Agarwal wrote:
>>> Initialize the platform data and enable video driver
>>> probe of SM8250 SoC.
>>>
>>> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
>>> ---
>> [..] 
>>> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
>>> index 86ef2e5c488e..a2aadd48926f 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_probe.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
>>> @@ -325,6 +325,10 @@ static const struct of_device_id iris_dt_match[] = {
>>>  		.compatible = "qcom,sm8550-iris",
>>>  		.data = &sm8550_data,
>>>  	},
>>> +	{
>>> +		.compatible = "qcom,sm8250-venus",
>>> +		.data = &sm8250_data,
>>> +	},
>>>  	{ },
>>>  };
>>>  MODULE_DEVICE_TABLE(of, iris_dt_match);
>>
>> qcom-venus driver has already supported sm8250 soc, I think you should add
>> an extra patch to drop sm8250 releated code from qcom-venus driver if you
>> tend to add support for sm8250 in qcom-iris driver.
> 
> Iris driver did not feature parity with the venus driver, so it is
> expected that two drivers will exist side by side for some time.
> Nevertheless ideally we should have a way to specify which driver should
> be used for sm8250 (and other platforms being migrated).
> 
Agree, we should have a way to specify this. Any suggestions to achieve
this are welcomed.