Re: [PATCH] resource: Remove dependency on SPARSEMEM from GET_FREE_REGION

From: David Hildenbrand
Date: Tue Oct 15 2024 - 06:36:05 EST


On 15.10.24 10:03, Huang, Ying wrote:
Hi, David,

David Hildenbrand <david@xxxxxxxxxx> writes:

On 15.10.24 07:15, Huang Ying wrote:
We want to use the functions configured via GET_FREE_REGION in
resource kunit tests. However, GET_FREE_REGION depends on SPARSEMEM.
This makes resource kunit tests cannot be built on some architectures
lacking SPARSEMEM. In fact, these functions doesn't depend on
SPARSEMEM now. So, remove dependency on SPARSEMEM from
GET_FREE_REGION.
Link:
https://lore.kernel.org/lkml/20240922225041.603186-1-linux@xxxxxxxxxxxx/
Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: David Hildenbrand <david@xxxxxxxxxx>
Cc: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
---
mm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index 4c9f5ea13271..33fa51d608dc 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -1085,7 +1085,6 @@ config HMM_MIRROR
depends on MMU
config GET_FREE_REGION
- depends on SPARSEMEM
bool
config DEVICE_PRIVATE

Added by

commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
Author: Dan Williams <dan.j.williams@xxxxxxxxx>
Date: Fri May 20 13:41:24 2022 -0700

resource: Introduce alloc_free_mem_region()

@Dan, any insight why that dependency was added?

Dan has explain it some what in the following email,

https://lore.kernel.org/lkml/66f5abd431dce_964f2294b9@xxxxxxxxxxxxxxxxxxxxxxxxx.notmuch/

This is reachable from the "Link:" tag in the patch.

That should be part of the patch description then :)

--
Cheers,

David / dhildenb