Re: [PATCH V12 net-next 07/10] net: hibmcge: Implement rx_poll function to receive packets

From: Paolo Abeni
Date: Tue Oct 15 2024 - 07:57:20 EST


On 10/15/24 13:41, Jijie Shao wrote:
on 2024/10/15 18:28, Paolo Abeni wrote:
Side note: the above always uses the maximum MTU for the packet size,
if the device supports jumbo frames (8Kb size packets), it will
produce quite bad layout for the incoming packets... Is the device
able to use multiple buffers for the incoming packets?

In fact, jumbo frames are not supported in device, and the maximum MTU is 4Kb.

FTR, even 4Kb is bad enough: tiny packets (tcp syn, UDP dns req) will use a truesize above 5K. You can get a much better the layout using copybreak.

Cheers,

Paolo