Re: [PATCH v4 08/28] media: iris: implement power management

[kernel test robot]

Hi Dikshita,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 67cefecf2a039b9ed0030b9213ceafcd45e6f9e3]

url:    https://github.com/intel-lab-lkp/linux/commits/Dikshita-Agarwal/dt-bindings-media-Add-video-support-for-QCOM-SM8550-SoC/20241014-171950
base:   67cefecf2a039b9ed0030b9213ceafcd45e6f9e3
patch link:    https://lore.kernel.org/r/20241014-qcom-video-iris-v4-v4-8-c5eaa4e9ab9e%40quicinc.com
patch subject: [PATCH v4 08/28] media: iris: implement power management
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241015/202410151938.Q3kFJFnO-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241015/202410151938.Q3kFJFnO-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410151938.Q3kFJFnO-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/qcom/iris/iris_probe.c:281:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
     281 |         if (core->state != IRIS_CORE_INIT)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/platform/qcom/iris/iris_probe.c:289:9: note: uninitialized use occurs here
     289 |         return ret;
         |                ^~~
   drivers/media/platform/qcom/iris/iris_probe.c:281:2: note: remove the 'if' if its condition is always false
     281 |         if (core->state != IRIS_CORE_INIT)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     282 |                 goto exit;
         |                 ~~~~~~~~~
   drivers/media/platform/qcom/iris/iris_probe.c:276:9: note: initialize the variable 'ret' to silence this warning
     276 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MODVERSIONS
   Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
   Selected by [y]:
   - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y]


vim +281 drivers/media/platform/qcom/iris/iris_probe.c

   272	
   273	static int iris_pm_suspend(struct device *dev)
   274	{
   275		struct iris_core *core;
   276		int ret;
   277	
   278		core = dev_get_drvdata(dev);
   279	
   280		mutex_lock(&core->lock);
 > 281		if (core->state != IRIS_CORE_INIT)
   282			goto exit;
   283	
   284		ret = iris_hfi_pm_suspend(core);
   285	
   286	exit:
   287		mutex_unlock(&core->lock);
   288	
   289		return ret;
   290	}
   291	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki