Re: [PATCH v8 6/7] xfs: Validate atomic writes

From: John Garry
Date: Tue Oct 15 2024 - 08:25:56 EST


On 15/10/2024 13:16, Christoph Hellwig wrote:
On Tue, Oct 15, 2024 at 09:01:41AM +0000, John Garry wrote:
Validate that an atomic write adheres to length/offset rules. Currently
we can only write a single FS block.
+ if (iocb->ki_flags & IOCB_ATOMIC) {
+ if (ocount != ip->i_mount->m_sb.sb_blocksize)
+ return -EINVAL;
Maybe throw in a comment here why we are currently limited to atomic
writes of exactly the file system block size and don't allow smaller
values.


ok

Otherwise this looks good to me.

cheers