Re: [PATCH v6 7/8] iio: dac: ad3552r: add high-speed platform driver

From: David Lechner
Date: Tue Oct 15 2024 - 10:48:33 EST


On 10/15/24 2:15 AM, Nuno Sá wrote:
> On Mon, 2024-10-14 at 12:08 +0200, Angelo Dureghello wrote:
>> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx>

...

>> + } else {
>> + err = ad3552r_qspi_update_reg_bits(st,
>> + AD3552R_REG_ADDR_INTERFACE_CONFIG_A,
>> + AD3552R_MASK_SOFTWARE_RESET,
>> + AD3552R_MASK_SOFTWARE_RESET, 1);
>> + if (err)
>> + return err;
>> + }
>> + msleep(100);
>
> nit: fsleep()
>

fsleep() is microseconds, but we really do want milliseconds here.
Datasheet t_18 is 100 ms. (Internally, fsleep() calls msleep()
for anything over 20 ms anyway so makes more sense to just call
msleep() directly and avoid 3 extra 0s.)