Re: [PATCH] Revert "blk-throttle: Fix IO hang for a corner case"

From: Tejun Heo
Date: Tue Oct 15 2024 - 10:59:44 EST


On Fri, Oct 11, 2024 at 09:47:24AM +0800, Xiuhong Wang wrote:
> This reverts commit 5b7048b89745c3c5fb4b3080fb7bced61dba2a2b.
>
> The throtl_adjusted_limit function was removed after
> commit bf20ab538c81 ("blk-throttle: remove
> CONFIG_BLK_DEV_THROTTLING_LOW"), so the problem of not being
> able to scale after setting bps or iops to 1 will not occur.
> So revert this commit that bps/iops can be set to 1.
>
> Cc: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> Cc: Yu Kuai <yukuai3@xxxxxxxxxx>
> Signed-off-by: Xiuhong Wang <xiuhong.wang@xxxxxxxxxx>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@xxxxxxxxxx>

Please update the description to clarify that it's mostly a cleanup. Other
than that:

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun