[PATCH] net: plip: fix break; causing plip to never transmit

From: Jakub Boehm via B4 Relay
Date: Tue Oct 15 2024 - 11:16:21 EST


From: Jakub Boehm <boehm.jakub@xxxxxxxxx>

Since commit
71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")

plip was not able to send any packets, this patch replaces one
unintended break; with fallthrough; which was originally missed by
commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").

I have verified with a real hardware PLIP connection that everything
works once again after applying this patch.

Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
Signed-off-by: Jakub Boehm <boehm.jakub@xxxxxxxxx>
---
drivers/net/plip/plip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
index e39bfaefe8c50ba72238d04f08deaa46ca650c70..d81163bc910a3bcaa770a10c0e2d7d9b334a381b 100644
--- a/drivers/net/plip/plip.c
+++ b/drivers/net/plip/plip.c
@@ -815,7 +815,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
return HS_TIMEOUT;
}
}
- break;
+ fallthrough;

case PLIP_PK_LENGTH_LSB:
if (plip_send(nibble_timeout, dev,

---
base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
change-id: 20241015-net-plip-tx-fix-822e94e58a6e

Best regards,
--
Jakub Boehm <boehm.jakub@xxxxxxxxx>