Re: [PATCH V2][next] Bluetooth: btintel_pcie: Remove structually deadcode

From: Shuah Khan
Date: Tue Oct 15 2024 - 12:01:33 EST


On 10/15/24 03:48, Dan Carpenter wrote:
The subject has a typo. s/structually/structurally/

The intel bluetooth module was successfully built after the change
without any errors.


Delete this sentence. It should just be assumed that changes don't break the
build. You can put that code isn't tested under the --- cut off line, if you
want to put a warning message. But we don't need this in the permanent git log.


This issue was reported by Coverity Scan.
https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600709

Restating what I said in your other coverity patch, include
the coverity warning. This link requires login and no use
for people who don't have coverity account.

In the future don't include link that require login in the
commit logs.


Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware")
Signed-off-by: Everest K.C. <everestkc@xxxxxxxxxxxxxxxx>
---
^^^
Cut off line.

regards,
dan carpenter


thanks,
-- Shuah