Re: [PATCH v5 12/22] media: rzg2l-cru: Inline calculating image size

From: Lad, Prabhakar
Date: Tue Oct 15 2024 - 13:43:58 EST


Hi Laurent,

Thank you for the review.

On Tue, Oct 15, 2024 at 11:22 AM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Fri, Oct 11, 2024 at 06:30:42PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > The `rzg2l_cru_format_sizeimage()` function has been inlined into the
> > `rzg2l_cru_format_align()` function as it has a single caller.
>
> The commit message should use the imperative mood:
>
> Inline the `rzg2l_cru_format_sizeimage()` function into its single
> caller as the function is trivial and is not expected to be called
> anywhere else.
>
I will update the commit message as above.

> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

Cheers,
Prabhakar