Re: [PATCH v5 13/22] media: rzg2l-cru: Simplify handling of supported formats

From: Lad, Prabhakar
Date: Tue Oct 15 2024 - 13:48:14 EST


Hi Laurent,

Thank you for the review.

On Tue, Oct 15, 2024 at 11:23 AM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Fri, Oct 11, 2024 at 06:30:43PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Refactor the handling of supported formats in the RZ/G2L CRU driver by
> > moving the `rzg2l_cru_ip_format` struct to the common header for reuse
> > across multiple files and adding `pixelformat` and `bpp` members to it.
>
> The structure is already in a common header. You can write
>
> Refactor the handling of supported formats in the RZ/G2L CRU driver by
> adding `pixelformat` and `bpp` members to the `rzg2l_cru_ip_format`
> structure.
>
I will update the commit message as above.

Cheers,
Prabhakar