Re: [PATCH V3][next] Bluetooth: btintel_pcie: Remove structually deadcode

[Everest K.C.]

On Tue, Oct 15, 2024 at 4:27 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On 10/15/24 13:30, Everest K.C. wrote:
> > The switch case statement has a default branch. Thus, the return
> > statement at the end of the function can never be reached.
> > Fix it by removing the return statement at the end of the
> > function.
> >
> > This issue was reported by Coverity Scan.
>
> You forgot to fix the typo Dan pointed out in the short log.
> Don't forget to include reviewers when you send new version
> based on their comments.
I missed that feedback from Dan. Will include it in V4.
Also, will include Dan in V4.
> + Adding Dan
> >
> > Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware")
> > Signed-off-by: Everest K.C. <everestkc@xxxxxxxxxxxxxxxx>
> > ---
> > V2 -> V3: - Removed that the change was successfully built
> >         - Removed the link to Coverity Scan report
> > V1 -> V2: - Changed "Fixing" to "Fix" in the changelog
> >            - Added that the change was successfully built
> >            - Added kernel-janitors mailing list to CC
> >
> >   drivers/bluetooth/btintel_pcie.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> > index e4ae8c898dfd..660496e55276 100644
> > --- a/drivers/bluetooth/btintel_pcie.c
> > +++ b/drivers/bluetooth/btintel_pcie.c
> > @@ -391,7 +391,6 @@ static inline char *btintel_pcie_alivectxt_state2str(u32 alive_intr_ctxt)
> >       default:
> >               return "unknown";
> >       }
> > -     return "null";
> >   }
> >
> >   /* This function handles the MSI-X interrupt for gp0 cause (bit 0 in
>
> With the typo fixed:
>
> Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
>
> thanks,
> -- Shuah
Thanks,
Everest K.C.