Re: [PATCH net] net: systemport: fix potential memory leak in bcm_sysport_xmit()

[Florian Fainelli]

On 10/15/24 12:54, Jakub Kicinski wrote:
> On Tue, 15 Oct 2024 11:07:29 -0700 Florian Fainelli wrote:
> > > > Since we already have a private counter tracking DMA mapping errors, I
> > > > would follow what the driver does elsewhere in the transmit path,
> > > > especially what bcm_sysport_insert_tsb() does, and just use
> > > > dev_consume_skb_any() here.
> > >
> > > Are you saying that if the packet drop is accounted is some statistics
> > > we should not inform drop monitor about it? 🤔️
> > > That wasn't my understanding of kfree_skb vs consume_skb..
> >
> > Yes that's my reasoning here, now given that we have had packet drops on
> > transmit that took forever to track down, maybe I better retract that
> > statement and go with v1.
>
> Sounds good, we can apply v1. Would you like to ack/review here?

Yes, now done, thanks!
--
Florian