Re: [PATCH net v5 08/10] ip6mr: Lock RCU before ip6mr_get_table() call in ip6_mroute_getsockopt()

From: Jakub Kicinski
Date: Tue Oct 15 2024 - 20:10:27 EST


On Mon, 14 Oct 2024 17:05:54 +0200 Stefan Wiehler wrote:
> + rcu_read_lock();
> mrt = ip6mr_get_table(net, raw6_sk(sk)->ip6mr_table ? : RT6_TABLE_DFLT);
> + rcu_read_unlock();
> if (!mrt)
> return -ENOENT;

presumably you're trying to protect mrt with RCU?
so using mrt after unlocking is not right, you gotta hold the lock
longer
--
pw-bot: cr