Re: [PATCH v1 09/10] media: platform: mediatek: add isp_7x build config

[CK Hu (胡俊光)]

Hi, Shu-hsiang:

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Add Kconfig and Makefile to include MTK ISP CAMSYS, integrating
> the driver into the kernel build and configuration process.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---

[snip]

> --- /dev/null
> +++ b/drivers/media/platform/mediatek/isp/isp_7x/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +subdir-ccflags-y += -Werror
> +
> +subdir-ccflags-$(CONFIG_VIDEO_MTK_ISP_71_CAMSYS) += -DISP7_1
> +
> +obj-$(CONFIG_VIDEO_MTK_ISP_71_CAMSYS) += camsys/
> diff --git a/drivers/media/platform/mediatek/isp/isp_7x/camsys/Makefile b/drivers/media/platform/mediatek/isp/isp_7x/camsys/Makefile
> new file mode 100644
> index 000000000000..8e758cf6877f
> --- /dev/null
> +++ b/drivers/media/platform/mediatek/isp/isp_7x/camsys/Makefile
> @@ -0,0 +1,16 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2022 MediaTek Inc.
> +
> +mtk-cam-isp-objs := mtk_cam.o mtk_cam-raw.o mtk_cam-pool.o \
> +		    mtk_cam-video.o mtk_cam-ctrl.o \
> +		    mtk_cam-seninf-route.o mtk_cam-seninf-drv.o \

When you add mtk_cam-seninf-route.c and mtk_cam-seninf-drv.c in patch [3/10],
you should create this Makefile so these two .c file could be compiled.

Regards,
CK

> +		    mtk_cam-debug.o \
> +		    mtk_cam-raw_debug.o \
> +		    mtk_cam-feature.o mtk_cam-timesync.o
> +
> +mtk-cam-plat-util-objs :=  mtk_cam-plat-util.o
> +
> +include $(src)/mtk_csi_phy_2_0/Makefile
> +
> +obj-$(CONFIG_VIDEO_MTK_ISP_71_CAMSYS) += mtk-cam-plat-util.o
> +obj-$(CONFIG_VIDEO_MTK_ISP_71_CAMSYS) += mtk-cam-isp.o