RE: [PATCH] scsi: ufs: Use wait-for-reg in HCE init

[Avri Altman]

> On 10/14/24 9:57 PM, Avri Altman wrote:
> > Instead of open-coding it.  Code simplification - no functional change.
> 
> Please use full sentences in the patch description.
Done.

> 
> > +     while (retry) {
> 
> Please change this loop from a while-loop into a for-loop.
Done.

> 
> > +             if (!ufshcd_wait_for_register(hba, REG_CONTROLLER_ENABLE,
> CONTROLLER_ENABLE,
> > +                                           CONTROLLER_ENABLE, 1000, 50)) {
> > +                     break;
> >               } else {
> 
> "else" is not needed after a "break" statement, isn't it?
Done.

> 
> > +                     dev_err(hba->dev, "Controller enable failed\n");
> 
> Please fix the grammar of this message, e.g. by changing this message into
> "Enabling controller failed" or "Enabling the controller failed".
Done.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.