Re: [PATCH] m68k: mcfgpio: Fix incorrect register offset for CONFIG_M5441x

From: Geert Uytterhoeven
Date: Wed Oct 16 2024 - 02:57:18 EST


Hi Jean-Michel,

Thanks for your patch!

On Wed, Oct 16, 2024 at 8:45 AM Jean-Michel Hautbois
<jeanmichel.hautbois@xxxxxxxxxx> wrote:
> Fix a typo in the CONFIG_M5441x preprocessor condition, where the GPIO
> register offset was incorrectly set to 8 instead of 0. This prevented
> proper GPIO configuration for m5441x targets.
>
> Fixes: 83c6bdb827c9 ("m68knommu: Implement gpio support for m54xx.")

The typo was introduced in a different commit, so the correct tag would be
Fixes: bea8bcb12da09bd3 ("m68knommu: Add support for the Coldfire m5441x.")

> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@xxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds