Re: [PATCH] staging: gpib: Remove a dead condition in if statement
From: Greg KH
Date: Wed Oct 16 2024 - 03:38:44 EST
On Tue, Oct 15, 2024 at 02:06:47PM -0600, Everest K.C. wrote:
> The variable `residue` is an unsigned int, also the function
> `fluke_get_dma_residue` returns an unsigned int. The value of
> an unsigned int can only be 0 at minimum.
> The less-than-zero comparision can never be true.
> Fix it by removing the dead condition in the if statement.
>
> This issue was reported by Coverity Scan.
> Report:
> CID 1600782: (#1 of 1): Macro compares unsigned to 0 (NO_EFFECT)
> unsigned_compare: This less-than-zero comparison of an unsigned value
> is never true. residue < 0U.
>
> Fixes: 55936779f496 ("staging: gpib: Add Fluke cda based cards GPIB driver")
Again, a code cleanup does not deserve a "Fixes:" tag, sorry.
thanks,
greg k-h