Re: [PATCH] eth: fbnic: add CONFIG_PTP_1588_CLOCK_OPTIONAL dependency

[Vadim Fedorenko]

On 16/10/2024 07:22, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> fbnic fails to link as built-in when PTP support is in a loadable
> module:
>
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_ethtool.o: in function `fbnic_get_ts_info':
> fbnic_ethtool.c:(.text+0x428): undefined reference to `ptp_clock_index'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_time_start':
> fbnic_time.c:(.text+0x820): undefined reference to `ptp_schedule_worker'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_ptp_setup':
> fbnic_time.c:(.text+0xa68): undefined reference to `ptp_clock_register'
>
> Add the appropriate dependency to enforce this.
>
> Fixes: 6a2b3ede9543 ("eth: fbnic: add RX packets timestamping support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks!
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>