Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres
From: Andy Shevchenko
Date: Wed Oct 16 2024 - 05:09:14 EST
On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote:
> In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed to
> pcim_iomap_regions() is placed on the stack. Neither
> pcim_iomap_regions() nor the functions it calls copy that string.
>
> Should the string later ever be used, this, consequently, causes
> undefined behavior since the stack frame will by then have disappeared.
>
> Fix the bug by allocating the strings on the heap through
> devm_kasprintf().
> ---
I haven't found the reason for resending. Can you elaborate here?
--
With Best Regards,
Andy Shevchenko