Re: [PATCH v2 05/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver

From: Uwe Kleine-König
Date: Wed Oct 16 2024 - 05:36:52 EST


Hello,

On Thu, Oct 10, 2024 at 02:36:57PM -0500, Mario Limonciello wrote:
> +static struct platform_driver amd_hfi_driver = {
> + .driver = {
> + .name = AMD_HFI_DRIVER,
> + .owner = THIS_MODULE,
> + .acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
> + },
> + .probe = amd_hfi_probe,
> + .remove_new = amd_hfi_remove,
> +};

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers. Please just drop "_new".

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature