Re: [PATCH v6 2/2] clk: mediatek: Add drivers for MediaTek MT6735 main clock and reset drivers

From: AngeloGioacchino Del Regno
Date: Wed Oct 16 2024 - 05:57:35 EST


Il 16/10/24 11:28, Uwe Kleine-König ha scritto:
Hello,

On Thu, Oct 10, 2024 at 04:26:57PM +0300, Yassine Oudjana wrote:
+static struct platform_driver clk_mt6735_apmixedsys = {
+ .probe = clk_mt6735_apmixed_probe,
+ .remove_new = clk_mt6735_apmixed_remove,
+ .driver = {
+ .name = "clk-mt6735-apmixedsys",
+ .of_match_table = of_match_mt6735_apmixedsys,
+ },
+};

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers. Please just drop "_new".


Oh wow, I didn't notice that during my review. Sorry about that.

Cheers,
Angelo