Re: [PATCH net-next v3 7/8] rust: Add read_poll_timeout functions
From: Miguel Ojeda
Date: Wed Oct 16 2024 - 07:06:35 EST
On Wed, Oct 16, 2024 at 10:52 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> `__might_sleep`. The thing is, `::core::file!()` doesn't give us a
> nul-terminated string either, so this code is probably incorrect
> as-is.
Yeah, elsewhere we use `c_str!`. It would be nice to get
`core::c_file!` too, though that one is less critical since we can do
it ourselves. Perhaps we should also consider using Clippy's
`disallowed_macros` too if we don't expect people to often need the
normal one. Added to our list:
https://github.com/Rust-for-Linux/linux/issues/514
Cheers,
Miguel