Re: [PATCH V3] arm64: dts: qcom: qcm6490-idp: Allow UFS regulators load/mode setting

[Rakesh Kota]

On 10/16/2024 3:54 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 16, 2024 at 03:35:11PM +0530, Rakesh Kota wrote:
> > The UFS driver expects to be able to set load (and by extension, mode)
> > on its supply regulators. Add the necessary properties to make that
> > possible.
> >
> > Signed-off-by: Rakesh Kota <quic_kotarake@xxxxxxxxxxx>
> > ---
> > Changes V3:
> >   - Somehow after fixing the compilation in last patch, i have missed to
> >     do git  --amend the change. apology for that, in this change i have
> >     fixed that compilation issue.
>
> What actually was changed? The --amend doesn't describe changes. Nor
> does "fixed that compilation issue".
Added missing semicolon (;) after regulator-allow-set-load prop for ldo9 
regulator.
> >   - Link V2 : https://lore.kernel.org/all/20241015132049.2037500-1-quic_kotarake@xxxxxxxxxxx/
>
> Where are changes between v1 and v2?
i will add changes history in V4 patch.
> Where is the tag that was given to you for the v2?
sorry, i missed adding the Reviewed-by tag and i will add it in V4 patch.
> > ---
> >   arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > index 5f3d4807ac43..bfb1cdc238cc 100644
> > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > @@ -258,6 +258,8 @@ vreg_l6b_1p2: ldo6 {
> >   			regulator-name = "vreg_l6b_1p2";
> >   			regulator-min-microvolt = <1140000>;
> >   			regulator-max-microvolt = <1260000>;
> > +			regulator-allow-set-load;
> > +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM RPMH_REGULATOR_MODE_HPM>;
> >   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> >   		};
> >   
> > @@ -265,6 +267,8 @@ vreg_l7b_2p952: ldo7 {
> >   			regulator-name = "vreg_l7b_2p952";
> >   			regulator-min-microvolt = <2400000>;
> >   			regulator-max-microvolt = <3544000>;
> > +			regulator-allow-set-load;
> > +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM RPMH_REGULATOR_MODE_HPM>;
> >   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> >   		};
> >   
> > @@ -279,6 +283,8 @@ vreg_l9b_1p2: ldo9 {
> >   			regulator-name = "vreg_l9b_1p2";
> >   			regulator-min-microvolt = <1200000>;
> >   			regulator-max-microvolt = <1304000>;
> > +			regulator-allow-set-load;
> > +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM RPMH_REGULATOR_MODE_HPM>;
> >   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> >   		};
> >   
> > @@ -467,6 +473,8 @@ vreg_l10c_0p88: ldo10 {
> >   			regulator-name = "vreg_l10c_0p88";
> >   			regulator-min-microvolt = <720000>;
> >   			regulator-max-microvolt = <1050000>;
> > +			regulator-allow-set-load;
> > +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM RPMH_REGULATOR_MODE_HPM>;
> >   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> >   		};
> >   
> > --
> > 2.34.1