Re: [PATCH v9 3/8] block: Add bdev atomic write limits helpers
From: Christoph Hellwig
Date: Wed Oct 16 2024 - 08:29:38 EST
On Wed, Oct 16, 2024 at 10:03:20AM +0000, John Garry wrote:
> +static inline unsigned int
> +bdev_atomic_write_unit_min_bytes(struct block_device *bdev)
> +{
> + if (!bdev_can_atomic_write(bdev))
> + return 0;
Aren't the limits always zero when the block device doesn't support
atomic writes and we can skip these checks?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>