RE: [PATCH][next] crypto: tegra: remove redundant error check on ret

[Akhil R]

> Currently there is an unnecessary error check on ret without a proceeding
> assignment to ret that needs checking. The check is redundant and can be
> removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
>  drivers/crypto/tegra/tegra-se-aes.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/crypto/tegra/tegra-se-aes.c b/drivers/crypto/tegra/tegra-se-
> aes.c
> index ae7a0f8435fc..9d130592cc0a 100644
> --- a/drivers/crypto/tegra/tegra-se-aes.c
> +++ b/drivers/crypto/tegra/tegra-se-aes.c
> @@ -1180,8 +1180,6 @@ static int tegra_ccm_do_one_req(struct crypto_engine
> *engine, void *areq)
>                         goto out;
>         } else {
>                 rctx->cryptlen = req->cryptlen - ctx->authsize;
> -               if (ret)
> -                       goto out;
> 
>                 /* CTR operation */
>                 ret = tegra_ccm_do_ctr(ctx, rctx);
> --

Agreed. Thanks for pointing.

Acked-by: Akhil R <akhilrajeev@xxxxxxxxxx>

Regards,
Akhil