Re: [PATCH net] net/sun3_82586: fix potential memory leak in sun3_82586_send_packet()

From: Simon Horman
Date: Wed Oct 16 2024 - 09:49:39 EST


On Tue, Oct 15, 2024 at 10:41:48PM +0800, Wang Hai wrote:
> The sun3_82586_send_packet() returns NETDEV_TX_OK without freeing skb
> in case of skb->len being too long, add dev_kfree_skb() to fix it.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Wang Hai <wanghai38@xxxxxxxxxx>
> ---
> drivers/net/ethernet/i825xx/sun3_82586.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/i825xx/sun3_82586.c b/drivers/net/ethernet/i825xx/sun3_82586.c
> index f2d4669c81cf..58a3d28d938c 100644
> --- a/drivers/net/ethernet/i825xx/sun3_82586.c
> +++ b/drivers/net/ethernet/i825xx/sun3_82586.c
> @@ -1012,6 +1012,7 @@ sun3_82586_send_packet(struct sk_buff *skb, struct net_device *dev)
> if(skb->len > XMIT_BUFF_SIZE)
> {
> printk("%s: Sorry, max. framelength is %d bytes. The length of your frame is %d bytes.\n",dev->name,XMIT_BUFF_SIZE,skb->len);
> + dev_kfree_skb(skb);
> return NETDEV_TX_OK;
> }

Thanks,

I agree that:
* This code-change is correct,
* and in keeping with other code in this function.
* And I agree that this problem goes back to the beginning of git history

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>