Re: [PATCH v6 0/9] usb: gadget: uvc: effectively fill the udc isoc pipeline with available video buffers and fixes

From: Michael Grzeschik
Date: Wed Oct 16 2024 - 10:02:33 EST


On Wed, Oct 16, 2024 at 10:47:00AM +0200, Greg Kroah-Hartman wrote:
On Sun, Sep 29, 2024 at 08:59:20PM +0200, Michael Grzeschik wrote:
This patch series is improving the size calculation and allocation of
the uvc requests. Using the selected frame duration of the stream it is
possible to calculate the number of requests based on the interval
length.

It also precalculates the request length based on the actual per frame
size for compressed formats.

For this calculations to work it was needed to rework the request
queueing by moving the encoding to one extra thread (in this case we
chose the qbuf) context.

Next it was needed to move the actual request enqueueing to one extra
thread which is kept busy to fill the isoc queue in the udc.

Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
---
Changes in v6:
- fixes in: ("usb: gadget: uvc: add trace of enqueued and completed requests")
- Link to v5: https://lore.kernel.org/r/20240403-uvc_request_length_by_interval-v5-0-2de78794365c@xxxxxxxxxxxxxx

Breaks the build for me:

In file included from drivers/usb/gadget/function/uvc_trace.h:60,
from drivers/usb/gadget/function/uvc_trace.c:11:
./include/trace/define_trace.h:95:42: fatal error: ./uvc_trace.h: No such file or directory
95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
| ^

what did you build this against?

I somehow managed to drop the CFLAGS for the uvc_trace.o
which was "CFLAGS_uvc_trace.o := -I$(src)"

This was just fixed in v7. Please try that one:

https://lore.kernel.org/all/20240403-uvc_request_length_by_interval-v7-0-e224bb1035f0@xxxxxxxxxxxxxx/

Thanks for testing this,
Michael

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature