Re: [PATCH][next] pinctrl: th1520: Fix potential null pointer dereference on func

From: Linus Walleij
Date: Wed Oct 16 2024 - 15:31:42 EST


On Wed, Oct 16, 2024 at 5:56 PM Colin Ian King <colin.i.king@xxxxxxxxx> wrote:

> The initialization of muxtype deferences pointer func before func
> is sanity checked with a null pointer check, hence we have a null
> pointer deference issue. Fix this by only deferencing func with
> the assignment to muxtype after func has been null pointer checked.
>
> Fixes: 1fc30cd92770 ("pinctrl: th1520: Factor out casts")
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Patch applied, added Reported-by Kees since he mailed about this too.

Yours,
Linus Walleij