Re: [PATCH] PCI: cpcihp: remove uneccessary field

From: Bjorn Helgaas
Date: Wed Oct 16 2024 - 15:46:15 EST


On Mon, Oct 14, 2024 at 10:19:17AM -0300, Guilherme Giacomo Simoes wrote:
> The hardware_test field in cpci_hp_controller_ops is uneccessary because
> no file is being used. How a pointer need a space in memory for storage
> the address (4 bytes in 32bits systems and 8 bytes in 64 bits sustems),
> remove this dead code to reduce resource consumption.
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@xxxxxxxxx>

Applied to pci/hotplug for v6.13, thanks!

> ---
> drivers/pci/hotplug/cpci_hotplug.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/cpci_hotplug.h b/drivers/pci/hotplug/cpci_hotplug.h
> index 6d8970d8c3f2..03fa39ab0c88 100644
> --- a/drivers/pci/hotplug/cpci_hotplug.h
> +++ b/drivers/pci/hotplug/cpci_hotplug.h
> @@ -44,7 +44,6 @@ struct cpci_hp_controller_ops {
> int (*enable_irq)(void);
> int (*disable_irq)(void);
> int (*check_irq)(void *dev_id);
> - int (*hardware_test)(struct slot *slot, u32 value);
> u8 (*get_power)(struct slot *slot);
> int (*set_power)(struct slot *slot, int value);
> };
> --
> 2.46.2
>