Re: [PATCH 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

[Shuah Khan]

On 10/11/24 02:20, Lorenzo Stoakes wrote:
> On Thu, Oct 10, 2024 at 05:16:22PM -0600, Shuah Khan wrote:
> > On 10/10/24 12:15, Lorenzo Stoakes wrote:
> > > Add tests to assert that PIDFD_SELF_* correctly refers to the current
> > > thread and process.
> > >
> > > This is only practically meaningful to pidfd_send_signal() and
> > > pidfd_getfd(), but also explicitly test that we disallow this feature for
> > > setns() where it would make no sense.
> > >
> > > We cannot reasonably wait on ourself using waitid(P_PIDFD, ...) so while in
> > > theory PIDFD_SELF_* would work here, we'd be left blocked if we tried it.
> > >
> > > We defer testing of mm-specific functionality which uses pidfd, namely
> > > process_madvise() and process_mrelease() to mm testing (though note the
> > > latter can not be sensibly tested as it would require the testing process
> > > to be dying).
> > >
> > > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> > > ---
> > >    tools/testing/selftests/pidfd/pidfd.h         |   8 ++
> > >    .../selftests/pidfd/pidfd_getfd_test.c        | 136 ++++++++++++++++++
> > >    .../selftests/pidfd/pidfd_setns_test.c        |  11 ++
> > >    tools/testing/selftests/pidfd/pidfd_test.c    |  67 +++++++--
> > >    4 files changed, 213 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h
> > > index 88d6830ee004..1640b711889b 100644
> > > --- a/tools/testing/selftests/pidfd/pidfd.h
> > > +++ b/tools/testing/selftests/pidfd/pidfd.h
> > > @@ -50,6 +50,14 @@
> > >    #define PIDFD_NONBLOCK O_NONBLOCK
> > >    #endif
> > > +/* System header file may not have this available. */
> > > +#ifndef PIDFD_SELF_THREAD
> > > +#define PIDFD_SELF_THREAD -100
> > > +#endif
> > > +#ifndef PIDFD_SELF_THREAD_GROUP
> > > +#define PIDFD_SELF_THREAD_GROUP -200
> > > +#endif
> > > +
> >
> > Can't we pick these up from linux/pidfd.h - patch 2/3 adds
> > them.
>
> We're running this file in userland and it's not obvious we can correctly
> import this header, it'd be some "../../" thing out of the testing root
> directory and might not interact well with all scenarios in which this file
> is built.
>
> Also the existing tests do not seem to try to import that header, so it
> seemed the safest way of doing this.

kselftest has dependency on "make headers" and tests include
headers from linux/ directory

These local make it difficult to maintain these tests in the
longer term. Somebody has to go clean these up later.

The import will be fine and you can control that with -I flag in
the makefile. Remove these and try to get including linux/pidfd.h
working.

I see your v2 and v3. Please revise this patch to include the
header file and remove these local defines.

thanks,
-- Shuah