Re: Re:Re:[PATCH v5] rockchip/drm: vop2: add support for gamma LUT

[Daniel Stone]

Hi Piotr,

On Wed, 16 Oct 2024 at 20:19, Piotr Zalewski <pZ010001011111@xxxxxxxxx> wrote:
> On Wednesday, October 16th, 2024 at 2:27 PM, Daniel Stone <daniel@xxxxxxxxxxxxx> wrote:
> > 1 is the only solution that can work. Silently changing the colour
> > properties of a separate CRTC is not OK, since this can lead to
> > displaying incorrect content.
>
> Ok right kernel keeps track of the state and sees gamma as enabled even if
> dsp lut en bit was cleared.
>
> Would it be better to check if gamma is already enabled on another CRTC in
> atomic_check rather than atomic_begin/atomic_flush (and silently fail) like
> in[1]?

Yes please, that's exactly it. If userspace requests something that
can't be done, then fail the request.

Cheers,
Daniel