Re: [PATCH] clk: qcom: videocc-sm8350: use HW_CTRL_TRIGGER for vcodec GDSCs

From: Bjorn Andersson
Date: Wed Oct 16 2024 - 16:43:37 EST



On Sun, 01 Sep 2024 11:30:24 +0200, Johan Hovold wrote:
> A recent change in the venus driver results in a stuck clock on the
> Lenovo ThinkPad X13s, for example, when streaming video in firefox:
>
> video_cc_mvs0_clk status stuck at 'off'
> WARNING: CPU: 6 PID: 2885 at drivers/clk/qcom/clk-branch.c:87 clk_branch_wait+0x144/0x15c
> ...
> Call trace:
> clk_branch_wait+0x144/0x15c
> clk_branch2_enable+0x30/0x40
> clk_core_enable+0xd8/0x29c
> clk_enable+0x2c/0x4c
> vcodec_clks_enable.isra.0+0x94/0xd8 [venus_core]
> coreid_power_v4+0x464/0x628 [venus_core]
> vdec_start_streaming+0xc4/0x510 [venus_dec]
> vb2_start_streaming+0x6c/0x180 [videobuf2_common]
> vb2_core_streamon+0x120/0x1dc [videobuf2_common]
> vb2_streamon+0x1c/0x6c [videobuf2_v4l2]
> v4l2_m2m_ioctl_streamon+0x30/0x80 [v4l2_mem2mem]
> v4l_streamon+0x24/0x30 [videodev]
>
> [...]

Applied, thanks!

[1/1] clk: qcom: videocc-sm8350: use HW_CTRL_TRIGGER for vcodec GDSCs
commit: f903663a8dcd6e1656e52856afbf706cc14cbe6d

Best regards,
--
Bjorn Andersson <andersson@xxxxxxxxxx>