Re: [PATCH 00/12] Module Validation Refactor

From: Sami Tolvanen
Date: Wed Oct 16 2024 - 20:45:03 EST


Hi,

On Tue, Oct 15, 2024 at 4:16 PM Matthew Maurer <mmaurer@xxxxxxxxxx> wrote:
>
> Split out from Extended MODVERSIONS Support [1]
>
> This series refactors module validation during loading to ensure that
> everything is checked on its way in. This is intended to make the code
> robust enough that we can more confidently add new pieces like extended
> MODVERSIONS.
>
> [1] https://lore.kernel.org/all/20240925233854.90072-1-mmaurer@xxxxxxxxxx/
>
> Matthew Maurer (12):
> module: Take const arg in validate_section_offset
> module: Factor out elf_validity_ehdr
> module: Factor out elf_validity_cache_sechdrs
> module: Factor out elf_validity_cache_secstrings
> module: Factor out elf_validity_cache_index_info
> module: Factor out elf_validity_cache_index_mod
> module: Factor out elf_validity_cache_index_sym
> module: Factor out elf_validity_cache_index_str
> module: Group section index calculations together
> module: Factor out elf_validity_cache_strtab
> module: Additional validation in elf_validity_cache_strtab
> module: Reformat struct for code style
>
> kernel/module/internal.h | 7 +-
> kernel/module/main.c | 569 +++++++++++++++++++++++++++++----------
> 2 files changed, 428 insertions(+), 148 deletions(-)

Looks like these patches are unchanged from the pre-split version[1].
For the series:

Reviewed-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>

[1] https://lore.kernel.org/linux-modules/20240925233854.90072-1-mmaurer@xxxxxxxxxx/

Sami