Re: [PATCH v2] selftest/tcp-ao: Add filter tests

[Dmitry Safonov]

On Wed, 16 Oct 2024 at 06:59, Leo Stone <leocstone@xxxxxxxxx> wrote:
>
> Add tests that check if getsockopt(TCP_AO_GET_KEYS) returns the right
> keys when using different filters.
>
> Sample output:
>
> > # ok 114 filter keys: by sndid, rcvid, address
> > # ok 115 filter keys: by is_current
> > # ok 116 filter keys: by is_rnext
> > # ok 117 filter keys: by sndid, rcvid
> > # ok 118 filter keys: correct nkeys when in.nkeys < matched_keys
>
> Signed-off-by: Leo Stone <leocstone@xxxxxxxxx>

LGTM, thank you!

Acked-by: Dmitry Safonov <0x7f454c46@xxxxxxxxx>

> ---
> Changes in v2:
> - Changed 2 unnecessary test_error calls to test_fail
> - Added another test to make sure getsockopt returns the right nkeys
>   value when the input nkeys is smaller than the number of matching keys
> - Removed the TODO that this patch addresses
>
> Thank you for your feedback.
[..]

Thanks,
             Dmitry