RE: [PATCH net-next 02/13] net: fec: struct fec_enet_private: remove obsolete comment

From: Wei Fang
Date: Wed Oct 16 2024 - 21:37:49 EST


> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: 2024年10月17日 5:52
> To: Wei Fang <wei.fang@xxxxxxx>; Shenwei Wang <shenwei.wang@xxxxxxx>;
> Clark Wang <xiaoning.wang@xxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Richard
> Cochran <richardcochran@xxxxxxxxx>
> Cc: imx@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Subject: [PATCH net-next 02/13] net: fec: struct fec_enet_private: remove
> obsolete comment
>
> In commit 4d494cdc92b3 ("net: fec: change data structure to support
> multiqueue") the data structures were changed, so that the comment
> about the sent-in-place skb doesn't apply any more. Remove it.
>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/freescale/fec.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec.h
> b/drivers/net/ethernet/freescale/fec.h
> index
> 77c2a08d23542accdb85b37a6f86847d9eb56a7a..e55c7ccad2ec39a9f349213
> 5675d480a22f7032d 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -614,7 +614,6 @@ struct fec_enet_private {
> unsigned int num_tx_queues;
> unsigned int num_rx_queues;
>
> - /* The saved address of a sent-in-place packet/buffer, for skfree(). */
> struct fec_enet_priv_tx_q *tx_queue[FEC_ENET_MAX_TX_QS];
> struct fec_enet_priv_rx_q *rx_queue[FEC_ENET_MAX_RX_QS];
>
>
> --
> 2.45.2
>

Thanks.

Reviewed-by: Wei Fang <wei.fang@xxxxxxx>