Re: [PATCH net-next v3 3/8] rust: time: Change output of Ktime's sub operation to Delta

[FUJITA Tomonori]

On Wed, 16 Oct 2024 10:25:11 +0200
Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:

> On Wed, Oct 16, 2024 at 5:53 AM FUJITA Tomonori
> <fujita.tomonori@xxxxxxxxx> wrote:
>>
>> Change the output type of Ktime's subtraction operation from Ktime to
>> Delta. Currently, the output is Ktime:
>>
>> Ktime = Ktime - Ktime
>>
>> It means that Ktime is used to represent timedelta. Delta is
>> introduced so use it. A typical example is calculating the elapsed
>> time:
>>
>> Delta = current Ktime - past Ktime;
>>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxx>
> 
> So this means that you are repurposing Ktime as a replacement for
> Instant rather than making both a Delta and Instant type? Okay. That
> seems reasonable enough.

Yes.

Surely, we could create both Delta and Instant. What is Ktime used
for? Both can simply use bindings::ktime_t like the followings?

pub struct Instant {
    inner: bindings::ktime_t,
}

pub struct Delta {
    inner: bindings::ktime_t,
}