Re: [PATCH net-next 1/2] ethtool: rss: prevent rss ctx deletion when in use

From: Paolo Abeni
Date: Thu Oct 17 2024 - 04:21:50 EST




On 10/16/24 18:50, Daniel Zahka wrote:

On 10/16/24 12:23 PM, Edward Cree wrote:
On 15/10/2024 17:31, Daniel Zahka wrote:
On 10/14/24 6:10 AM, Edward Cree wrote:
Imho it would make more sense to add core tracking of ntuple
  filters, along with a refcount on the rss context.  That way
  context deletion just has to check the count is zero.

-ed
That sounds good to me. Is that something you are planning on sending patches for?
I'm afraid I don't have the bandwidth to do it any time soon.
If you aren't able to take this on, I'm okay with your original
approach to get the issue fixed; I just wanted to ensure the
'better' solution was considered if you do have the time for it.
Understood. I don't have enough bandwidth to commit to implementing it
soon either.

I understand the chances to have a refcount based implementation soon are zero, and I could not find any obvious problem with the proposed solution, I'm going to apply this series as-is.

Cheers,

Paolo